Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Send feedback directly to a dedicated slack channel #34196

Merged
merged 8 commits into from Sep 26, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Sep 5, 2022

For now, doc feedbacks are saved in a database. To reduce the gap between the readers and the developers, I propose also sending them into a slack channel to make them more visible.

It's a first step for mui/mui-x#5913

@alexfauquette alexfauquette added the docs Improvements or additions to the documentation label Sep 5, 2022
@mui-bot
Copy link

mui-bot commented Sep 5, 2022

No bundle size changes

Generated by 🚫 dangerJS against d8163c3

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We would also need to define the env variable in the next.config.js https://nextjs.org/docs/api-reference/next.config.js/environment-variables
  2. Which channel does it post on? Did we create a new one for the occasion?
  3. I assume it's coming from a custom app, however, I can't see it in https://api.slack.com/apps. Is it expected?

@alexfauquette
Copy link
Member Author

  1. Done
  2. I created doc-feedbacks to experiment and avoid spamming with test, but can be modified from slack API interface
  3. I added a custom app named doc feedbacks in slack workspace

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 17, 2022
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2022
@alexfauquette alexfauquette self-assigned this Sep 19, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great! looks easier to see feedback.

@alexfauquette alexfauquette merged commit 512936b into mui:master Sep 26, 2022
@alexfauquette alexfauquette deleted the slack-feedbacks branch September 26, 2022 14:13
alexfauquette added a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants