Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Improve image handling #34222

Merged
merged 1 commit into from Sep 17, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 7, 2022

The PR started with #33778 (comment), and then I moved to better handle some of https://www.notion.so/mui-org/Images-solution-30e78dbf24744ed5b570027656139092 for all the blog posts of the first page https://mui.com/blog/ with the hope it will server as an example for the future blog posts.

  1. ![]() has no use valid case, to ban.
  2. images outside of the viewport should have loading="lazy" to have faster loading time on mobile.
  3. images should have aspect-ratio to avoid layout shift when the image hasn't loaded yet.

@mui-bot
Copy link

mui-bot commented Sep 7, 2022

No bundle size changes

Generated by 🚫 dangerJS against 8e47377

@oliviertassinari oliviertassinari merged commit dec47d6 into mui:master Sep 17, 2022
@oliviertassinari oliviertassinari deleted the improve-blog-posts branch September 17, 2022 11:39
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants