New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectInput] Update menu to use select wrapper as anchor #34229
Conversation
|
I noticed an issue that is related to this one. If you use the Any chance that this PR addresses this issue as well? If not, I would be interested to know what it would take to fix that. Would be happy to help. mui-text-field-adornment.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. This seems to be working well.
We can simplify the implementation a little bit, though.
@mracette please open a separate issue and provide a reproduction sandbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small edit to correct the code I had a remark about.
It's good to go now. Thanks for your work!
hi, just wondering if the issue mentioned by @mracette ⬆️ was indeed opened on a separate issue? I'm facing this same issue. |
I can't find any issue related to it, feel free to open a new one. |
This PR fixes #33559
This PR fixes #32958 too
The
Menu
component fromSelectInput
was updated to occupy theSelect
full width even when it has an adornment.Before:
After: