Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectInput] Update menu to use select wrapper as anchor #34229

Merged
merged 3 commits into from Dec 22, 2022
Merged

[SelectInput] Update menu to use select wrapper as anchor #34229

merged 3 commits into from Dec 22, 2022

Conversation

EduardoSCosta
Copy link
Contributor

@EduardoSCosta EduardoSCosta commented Sep 8, 2022

This PR fixes #33559
This PR fixes #32958 too

The Menu component from SelectInput was updated to occupy the Select full width even when it has an adornment.

Before:
before

After:
after

@mui-bot
Copy link

mui-bot commented Sep 8, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34229--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against f6d8add

@EduardoSCosta EduardoSCosta changed the title [SelectInput] Update select menu to use parent element as anchor [SelectInput] Update menu to use select wrapper as anchor Sep 8, 2022
@mracette
Copy link
Contributor

mracette commented Oct 5, 2022

I noticed an issue that is related to this one. If you use the filled or standard variants with an adornment, the focused state will only darken the portion of the text input that doesn't contain the adornment.

Any chance that this PR addresses this issue as well? If not, I would be interested to know what it would take to fix that. Would be happy to help.

mui-text-field-adornment.mov

@michaldudak michaldudak added the component: select This is the name of the generic UI component, not the React module! label Oct 12, 2022
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. This seems to be working well.
We can simplify the implementation a little bit, though.


@mracette please open a separate issue and provide a reproduction sandbox.

packages/mui-material/src/Select/SelectInput.js Outdated Show resolved Hide resolved
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small edit to correct the code I had a remark about.
It's good to go now. Thanks for your work!

@michaldudak michaldudak merged commit 94f8c9f into mui:master Dec 22, 2022
@gl0gl0
Copy link

gl0gl0 commented Mar 10, 2023

I noticed an issue that is related to this one. If you use the filled or standard variants with an adornment, the focused state will only darken the portion of the text input that doesn't contain the adornment.

Any chance that this PR addresses this issue as well? If not, I would be interested to know what it would take to fix that.

hi, just wondering if the issue mentioned by @mracette ⬆️ was indeed opened on a separate issue? I'm facing this same issue.
Thanks!

@mnajdova
Copy link
Member

hi, just wondering if the issue mentioned by @mracette ⬆️ was indeed opened on a separate issue? I'm facing this same issue.
Thanks!

I can't find any issue related to it, feel free to open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module!
Projects
None yet
6 participants