[Fab] Add disabled class to FAB button
#34245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ZeeshanTamboli
changed the title
disabled class to FAB button
ZeeshanTamboli
added
bug 🐛
|
The |
meenarama
force-pushed
the
issue/34227-add-disabled-class-to-fab-button
branch
from
e08d0fc
to
3782714
Compare
|
@michaldudak, I did the same thing as in Icon Button, but I fixed multiple occurrences of Mui-disabled class. I guess Icon Button has the same behavior, FYI |
mnajdova
approved these changes
Sep 26, 2022
|
@mnajdova , thanks for this implementation, I tested this, looks good. can this be merged? |
|
@meenarama will merge it today, I've updated with the latest master, let's wait for the green CI :) |
oliviertassinari
added
the
component: button
|
@mnajdova , could you let me know which release, this will be in? |
|
It's released already @meenarama v5.10.8 |
|
@mnajdova , Yup, saw that, thx! |
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #34227
Similar Issue in the past:
[25072] (#25072)
What does it do?
Fixes disabled class not getting added to button element.
Why is it needed?
disabled class not working in Fab button