Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy][button] Replace start/endIcon prop with start/endDecorator #34288

Merged
merged 9 commits into from
Sep 15, 2022
Merged

[Joy][button] Replace start/endIcon prop with start/endDecorator #34288

merged 9 commits into from
Sep 15, 2022
+92 −79

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Sep 12, 2022 •
edited by siriwatknp
Loading

BREAKING CHANGE: replace start/endIcon with start/endDecorator.

// before
<Button startIcon={...} endIcon={...} />

// after
<Button startDecorator={...} endDecorator={...} />

Closes #34242

Sorry, something went wrong.

@hbjORbj hbjORbj changed the title [Joy][button] Replace start/endIcon prop with start/endDecorator [Joy][button] Replace start/endIcon prop with start/endDecorator Sep 12, 2022
@hbjORbj hbjORbj added breaking change component: button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 12, 2022
@hbjORbj hbjORbj self-assigned this Sep 12, 2022
@mui-bot
Copy link

mui-bot commented Sep 12, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against f9c50b5

siriwatknp
siriwatknp requested changes Sep 13, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbjORbj Thanks, Benny. Note that Argos should not detect any changes.

@hbjORbj hbjORbj requested review from siriwatknp and danilo-leal and removed request for mnajdova and michaldudak September 13, 2022 12:24
siriwatknp
siriwatknp reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the start/endDecorator slots to button in extendTheme.spec.ts as well? I think I missed it.

danilo-leal
danilo-leal approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me!

@hbjORbj hbjORbj force-pushed the joy/button-prop-rename branch from 94d6e4e to f9c50b5 Compare September 15, 2022 09:15
@hbjORbj hbjORbj requested a review from siriwatknp September 15, 2022 09:15
@hbjORbj
Copy link
Member Author

hbjORbj commented Sep 15, 2022

Can you add the start/endDecorator slots to button in extendTheme.spec.ts as well? I think I missed it.

@siriwatknp Done!

siriwatknp
siriwatknp approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Awesome @hbjORbj

@hbjORbj hbjORbj merged commit c39faa6 into mui:master Sep 15, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@hbjORbj
[Joy][button] Replace start/endIcon prop with start/endDecorator (m…
e7ec3f1 
…ui#34288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp

@danilo-leal danilo-leal

Assignees

@hbjORbj hbjORbj

Labels
breaking change component: button This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Joy][button] Replace start/endIcon prop with start/endDecorator
4 participants
@hbjORbj @mui-bot @siriwatknp @danilo-leal