Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add notification for MUI Base announcement post #34295

Merged
merged 3 commits into from Sep 14, 2022
Merged

[docs] Add notification for MUI Base announcement post #34295

merged 3 commits into from Sep 14, 2022

Conversation

samuelsycamore
Copy link
Member

This PR adds a notification to point readers to the MUI Base announcement post.

@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation blog labels Sep 12, 2022
@mui-bot
Copy link

mui-bot commented Sep 12, 2022 •
edited

No bundle size changes

Generated by 🚫 dangerJS against c03144e

danilo-leal
danilo-leal reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we can remove Joy's notification already, though, can't we?! Just so we're careful about the amount of stuff we leave piling up there.

michaldudak
michaldudak approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samuelsycamore
Copy link
Member Author

Looking good! I think we can remove Joy's notification already, though, can't we?! Just so we're careful about the amount of stuff we leave piling up there.

Good call @danilo-leal. I've removed some of the older notifications and just left this one and the other most recent one.

@samuelsycamore samuelsycamore merged commit d88ab9e into mui:master Sep 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@samuelsycamore
[docs] Add notification for MUI Base announcement post (mui#34295)
ccb65ba
@samuelsycamore samuelsycamore deleted the base-post-notification branch April 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal left review comments

@michaldudak michaldudak michaldudak approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
blog docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samuelsycamore @mui-bot @michaldudak @danilo-leal