Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Uplift introduction demos & make consistent with Base #34316

Merged
merged 42 commits into from Nov 21, 2022
Merged

[Joy] Uplift introduction demos & make consistent with Base #34316

merged 42 commits into from Nov 21, 2022

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Sep 15, 2022 •
edited

This pull request is:

  • Introducing a new gradient background style for Joy UI introduction demos. We're using MUI's branding theme colors instead of the Joy UI palette to keep it consistent⎯at least for now.
  • Adding a subtle tile to the normal component demos, to keep the pattern consistent and a bit more interesting than just an outlined container. It's something I'm looking forward to extending across the marketing site and other docs.
  • Fixing styles here and there & adjusting component demos so they look a bit better.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Sep 15, 2022
@mui-bot
Copy link

mui-bot commented Sep 15, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-34316--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 338078f

@siriwatknp
Copy link
Member

siriwatknp commented Sep 15, 2022 •
edited

🤩
Screen Shot 2565-09-15 at 13 23 41
Screen Shot 2565-09-15 at 13 23 56

@siriwatknp

This comment was marked as resolved.

Sign in to view
danilo-leal and others added 19 commits September 23, 2022 02:48
@danilo-leal
use same styles as in the Base demos
dbf1d5c
@danilo-leal
missed out toolbars
6cb0ed9
@danilo-leal
add tiles to normal outline demo bg
d9841ef
@danilo-leal
fix css vars interactive controls margin
51b3d52
@danilo-leal
a few missing components
47af82c
@danilo-leal
tweaking the colors a bit
1e46896
@danilo-leal
a bit more iterating on the demo background
631f3c1
@danilo-leal
min width to the playground demo
2759b26
@danilo-leal
text area typos
9d39e46
@danilo-leal
radio button demo tweaks
66cecfd
@danilo-leal
css vars playground shadow
f842e9f
@danilo-leal
general component demos refinement
f217d9b
@danilo-leal
revamping tabs demos
8ced5cf
@danilo-leal
yarn docs:typescript:formatted
5abd65a
@siriwatknp
Merge branch 'master' of https://github.com/mui/material-ui into joy-…
17d2aa5 
…demos-revamp
@siriwatknp
fix lint
b99009a
@danilo-leal
Merge branch 'master' of https://github.com/mui/material-ui into joy-…
58c838d 
…demos-revamp
@danilo-leal
Merge branch 'joy-demos-revamp' of https://github.com/danilo-leal/mat…
d33dd32 
…erial-ui into joy-demos-revamp
@danilo-leal
fix margin on CSS Vars demo type
39728a4
@danilo-leal danilo-leal marked this pull request as ready for review November 3, 2022 22:38
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 14, 2022
siriwatknp
siriwatknp approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@danilo-leal danilo-leal merged commit 709317c into mui:master Nov 21, 2022
@danilo-leal danilo-leal deleted the joy-demos-revamp branch November 21, 2022 09:16
@danilo-leal danilo-leal mentioned this pull request Nov 21, 2022
Merged
1 task
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Nov 22, 2022
@danilo-leal @siriwatknp @alexfauquette
[Joy] Uplift introduction demos & make consistent with Base (mui#34316)
f9a8b86 
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@danilo-leal @siriwatknp
[Joy] Uplift introduction demos & make consistent with Base (mui#34316)
9e301b6 
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@danilo-leal @siriwatknp
[Joy] Uplift introduction demos & make consistent with Base (mui#34316)
63643b4 
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danilo-leal @mui-bot @siriwatknp