Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix MUI X subscribe email border style #34330

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 15, 2022

We used to see this:

Screenshot 2022-09-16 at 00 23 07

https://62d59767934a0000083cd4e9--material-ui-docs.netlify.app/x/ (v5.9.1)

After #33585, we now have:

Screenshot 2022-09-16 at 00 23 32

https://62deb307440fcb0008f9665d--material-ui-docs.netlify.app/x/ (v5.9.2)

This PR removes the custom style, to have the same section look like this:

Screenshot 2022-09-16 at 00 24 18

https://deploy-preview-34330--material-ui.netlify.app/x/

I found this by chance while we were talking with MUI X about the need to refresh this marketing page. The page was created a year ago, things are evolving on MUI X.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work website Pages that are not documentation-related, marketing-focused. regression A bug, but worse labels Sep 15, 2022
@oliviertassinari oliviertassinari changed the title [website] Fix wrong border style [website] Fix MUI X subscribe email border style Sep 15, 2022
@mui-bot
Copy link

mui-bot commented Sep 15, 2022

No bundle size changes

Generated by 🚫 dangerJS against 343bb03

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! This definitely slipped through and it's looking much better 👌

Copy link

@ProKashif ProKashif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliviertassinari oliviertassinari merged commit 38ffb17 into mui:master Sep 17, 2022
@oliviertassinari oliviertassinari deleted the mui-x-fix-border-style branch September 17, 2022 11:18
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants