[TextField] Fix conflict with Bootstrap even when label is not defined
#34343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
the
component: text field
2 tasks
ZeeshanTamboli
changed the title
Bootstrap even when label is not defined
ZeeshanTamboli
requested review from
michaldudak and
mnajdova
as code owners
oliviertassinari
approved these changes
Sep 17, 2022
ZeeshanTamboli
deleted the
issue/34298-textfield-legend-style-bootstrap
branch
|
@ZeeshanTamboli This is a clean fix, thanks for the care. |
@oliviertassinari As usual, glad to be of help. :) |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
…ned (mui#34343) Co-authored-by: Michał Dudak <michal@dudak.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34298.
Even when label is not set in TextField, it should work correctly with bootstrap.
Similar issue #19463. It's PR - #19495.
I am not sure how
width: autoworks here. I just referred #19495.Before: https://codesandbox.io/s/charming-maria-vk4q3l?file=/src/App.tsx
After: https://codesandbox.io/s/young-water-09u5r0?file=/src/App.tsx