New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] Add author and published_time meta tags #34382
Conversation
|
Seems to work. I also included extra information: the authors and the publication date, such that algorithm could detect that it's fresh content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, it seems to be a continuation of #33954.
Regarding testing the changes, when I compare https://deploy-preview-34382--material-ui.netlify.app/blog/introducing-mui-base/ with https://mui.com/blog/introducing-mui-base/, I can only see one difference:
So I conclude that only <meta name="author" content="
makes a difference, the rest has no impacts 😁
Effectively, I don't know why I got the wrong image the first time 🤔 the prefix might not be a bad thing. If the date with the full date/time is recognized by LinkedIn it will be an improvement |
There seems to be a problem with the publication date still. Do you intend to fix it in this PR or is it solely about the preview image? |
@michaldudak Thanks for the reminder :) I tend to think that the LinkedIn parser is I had a look at two articles:
I inspeceted the meta tag, those with or are the same, so no reason one has it's date detected, and the other not I added the prefix for article tags: |
Yeah, that's strange indeed. Let's merge what we have. It's an improvement anyway. |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
5c49709
to
acd5aae
Compare
56855d7
to
54bad21
Compare
aca2cb4
to
59e5593
Compare
59e5593
to
6b1a473
Compare
I have rebased and pushed a few more improvements. |
@alexfauquette can we merge this so that we can include in the today's release? |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
/> | ||
> | ||
<meta name="author" content={headers.authors.map((key) => authors[key].name).join(', ')} /> | ||
<meta property="article:published_time" content={headers.date} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexfauquette Did you find a way to test if this was providing any win? Most seem to do this, e.g. https://medium.com/havingfun/rebuilding-loggis-design-system-on-top-of-material-ui-9555fede0466 or https://wordpress.com/blog/2022/10/17/free-new-course-coming-soon-create-your-site-with-wordpress-com/ but I don't get why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a battle between Facebook and Google with og
standard vs schema.org
. Since we do not know which service is using what, better to add them both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
I'm trying to fix the doc preview that has a bad preview image on LinkedIn. It seems to be a common Stack Overflow question that can be solved by defining the prefix in the header.
To do: test the preview with LinkedIn inspector: https://www.linkedin.com/post-inspector/ to see if the fix is working.
Preview: https://deploy-preview-34382--material-ui.netlify.app/blog/introducing-mui-base/
Before
https://www.linkedin.com/post-inspector/inspect/https:%2F%2Fmui.com%2Fblog%2Fintroducing-mui-base%2F
https://validator.schema.org/#url=https%3A%2F%2Fmui.com%2Fblog%2Fmui-x-v6-alpha-zero%2F
After
https://www.linkedin.com/post-inspector/inspect/https:%2F%2Fdeploy-preview-34382--material-ui.netlify.app%2Fblog%2Fintroducing-mui-base%2F
https://validator.schema.org/#url=https%3A%2F%2Fdeploy-preview-34382--material-ui.netlify.app%2Fblog%2Fmui-core-v5-migration-update%2F