Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Add author and published_time meta tags #34382

Merged
merged 11 commits into from Nov 2, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Sep 19, 2022

@mui-bot
Copy link

mui-bot commented Sep 19, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34382--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 59beaa3

@alexfauquette
Copy link
Member Author

Seems to work. I also included extra information: the authors and the publication date, such that algorithm could detect that it's fresh content

https://www.linkedin.com/post-inspector/inspect/https:%2F%2Fdeploy-preview-34382--material-ui.netlify.app%2Fblog%2Fintroducing-mui-base%2F

@alexfauquette alexfauquette marked this pull request as ready for review September 19, 2022 12:43
@oliviertassinari oliviertassinari changed the title [docs] add open-graph prefix [docs] Add open-graph prefix Sep 19, 2022
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it seems to be a continuation of #33954.

Regarding testing the changes, when I compare https://deploy-preview-34382--material-ui.netlify.app/blog/introducing-mui-base/ with https://mui.com/blog/introducing-mui-base/, I can only see one difference:

Screenshot 2022-09-19 at 16 30 48

So I conclude that only <meta name="author" content=" makes a difference, the rest has no impacts 😁

@alexfauquette
Copy link
Member Author

Interesting, it seems to be a continuation of #33954.

Regarding testing the changes, when I compare deploy-preview-34382--material-ui.netlify.app/blog/introducing-mui-base with mui.com/blog/introducing-mui-base, I can only see one difference:

Screenshot 2022-09-19 at 16 30 48

So I conclude that only <meta name="author" content=" makes a difference, the rest has no impacts grin

Effectively, I don't know why I got the wrong image the first time 🤔

the prefix might not be a bad thing. If the date with the full date/time is recognized by LinkedIn it will be an improvement

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Oct 14, 2022
@michaldudak
Copy link
Member

There seems to be a problem with the publication date still. Do you intend to fix it in this PR or is it solely about the preview image?

@alexfauquette
Copy link
Member Author

alexfauquette commented Oct 28, 2022

@michaldudak Thanks for the reminder :)

I tend to think that the LinkedIn parser is broken strange

I had a look at two articles:

I inspeceted the meta tag, those with or are the same, so no reason one has it's date detected, and the other not

I added the prefix for article tags: article: http://ogp.me/ns/article#" but does not seems to change the behavior

@michaldudak
Copy link
Member

Yeah, that's strange indeed. Let's merge what we have. It's an improvement anyway.

alexfauquette and others added 6 commits October 31, 2022 01:10
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@oliviertassinari oliviertassinari force-pushed the fix-linkedin-og branch 5 times, most recently from aca2cb4 to 59e5593 Compare October 31, 2022 01:20
@oliviertassinari
Copy link
Member

I have rebased and pushed a few more improvements.

@mnajdova
Copy link
Member

@alexfauquette can we merge this so that we can include in the today's release?

@alexfauquette alexfauquette changed the title [docs] Add open-graph prefix [docs] Add meta tags Oct 31, 2022
alexfauquette and others added 2 commits October 31, 2022 13:29
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
/>
>
<meta name="author" content={headers.authors.map((key) => authors[key].name).join(', ')} />
<meta property="article:published_time" content={headers.date} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a battle between Facebook and Google with og standard vs schema.org. Since we do not know which service is using what, better to add them both

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexfauquette alexfauquette changed the title [docs] Add meta tags [docs] Add author and published_time meta tags Nov 2, 2022
@alexfauquette alexfauquette merged commit 7c02152 into mui:master Nov 2, 2022
@alexfauquette alexfauquette deleted the fix-linkedin-og branch November 2, 2022 10:33
@oliviertassinari oliviertassinari changed the title [docs] Add author and published_time meta tags [blog] Add author and published_time meta tags Nov 2, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants