Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lab][deps] Move @mui/types to dependencies #34384

Merged
merged 1 commit into from Sep 26, 2022

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Sep 19, 2022

The @mui/lab package imports @mui/types package in its declaration files, so @mui/types should be a regular dependency instead of a devDependency.

ERROR in ../../.yarn/__virtual__/@mui-lab-virtual-b4b85e650c/0/cache/@mui-lab-npm-5.0.0-alpha.99-abf77ae8d8-db54edffbd.zip/node_modules/@mui/lab/TabList/TabList.d.ts:3:34
TS2307: Cannot find module '@mui/types' or its corresponding type declarations.
    1 | import * as React from 'react';
    2 | import { TabsTypeMap } from '@mui/material/Tabs';
  > 3 | import { DistributiveOmit } from '@mui/types';
      |                                  ^^^^^^^^^^^^
    4 | import { OverridableComponent, OverrideProps } from '@mui/material/OverridableComponent';
    5 |
    6 | export interface TabListTypeMap<

ERROR in ../../.yarn/__virtual__/@mui-lab-virtual-b4b85e650c/0/cache/@mui-lab-npm-5.0.0-alpha.99-abf77ae8d8-db54edffbd.zip/node_modules/@mui/lab/TimelineDot/TimelineDot.d.ts:2:40
TS2307: Cannot find module '@mui/types' or its corresponding type declarations.
    1 | import * as React from 'react';
  > 2 | import { OverridableStringUnion } from '@mui/types';
      |                                        ^^^^^^^^^^^^
    3 | import { SxProps } from '@mui/system';
    4 | import { Theme } from '@mui/material/styles';
    5 | import { InternalStandardProps as StandardProps } from '@mui/material';

@mui-bot
Copy link

mui-bot commented Sep 19, 2022

No bundle size changes

Generated by 🚫 dangerJS against e3f75d4

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnajdova mnajdova added typescript package: lab Specific to @mui/lab labels Sep 26, 2022
@mnajdova mnajdova merged commit a3b4103 into mui:master Sep 26, 2022
@Methuselah96 Methuselah96 deleted the move-mui-types-to-deps branch September 26, 2022 17:11
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: lab Specific to @mui/lab typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants