Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Add Divider component #34403

Merged
merged 29 commits into from Sep 23, 2022
Merged

[Joy] Add Divider component #34403

merged 29 commits into from Sep 23, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 21, 2022 •
edited

Preview: https://deploy-preview-34403--material-ui.netlify.app/joy-ui/react-divider/

Feature parity

  • supports children
  • able to control the child's position

Improvement

  • use CSS variable to control the child's position (Material UI uses prop which is not robust)
  • cleaner structure and classes (Material UI adds a wrapper to the child whereas Joy UI does not)
  • automatic adjustment when the Divider is a direct child of Card or ModalDialog
  • ListDivider now inherits Divider to leverage the children support feature.

Comparison

Material Joy % change
Divider 287 192 -33.10
total 287 192 -33.10

@siriwatknp siriwatknp added component: divider This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 21, 2022
@mui-bot
Copy link

mui-bot commented Sep 21, 2022 •
edited

Details of bundle changes

@mui/joy: parsed: +1.06% , gzip: +0.91%

Generated by 🚫 dangerJS against cbb5f2c

danilo-leal
danilo-leal approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed just a few slight changes there － it's looking great 👌

@siriwatknp siriwatknp merged commit e09fd32 into mui:master Sep 23, 2022
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
@siriwatknp @alexfauquette
[Joy] Add Divider component (mui#34403)
abcf614
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@siriwatknp
[Joy] Add Divider component (mui#34403)
fc24d90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@hbjORbj hbjORbj Awaiting requested review from hbjORbj

@michaldudak michaldudak Awaiting requested review from michaldudak

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: divider This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriwatknp @mui-bot @danilo-leal