Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove outdated docsearch.js dependency #34421

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 21, 2022

We moved from the v2 (docsearch.js) to the v3 (@docsearch/react). https://docsearch.algolia.com/docs/DocSearch-v3.

https://deploy-preview-34421--material-ui.netlify.app/

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Sep 21, 2022
@mui-bot
Copy link

mui-bot commented Sep 21, 2022

No bundle size changes

Generated by 🚫 dangerJS against 62f0cc3

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 26, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 1, 2022
@oliviertassinari oliviertassinari changed the title [core] Remove outdated dependency [core] Remove outdated docsearch.js dependency Oct 1, 2022
@oliviertassinari oliviertassinari merged commit 139724a into mui:master Oct 1, 2022
@oliviertassinari oliviertassinari deleted the remove-dead-docsearch-dependency branch October 1, 2022 10:41
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 1, 2022

The PR has been open for over a week, I'm merging to unlock it, review or not.

alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants