Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Fix parsing of hsla colors in getLuminance #34437

Merged
merged 2 commits into from Sep 26, 2022
Merged

[system] Fix parsing of hsla colors in getLuminance #34437

merged 2 commits into from Sep 26, 2022

Conversation

pete-murphy
Copy link
Contributor

@pete-murphy pete-murphy commented Sep 22, 2022 •
edited

Fixes #34438

@pete-murphy pete-murphy changed the title [WIP] Support hsla in getLuminance [colorManipulator] Support hsla in getLuminance Sep 22, 2022
@mui-bot
Copy link

mui-bot commented Sep 22, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against e1644cd

@pete-murphy pete-murphy marked this pull request as ready for review September 22, 2022 18:32
@pete-murphy pete-murphy changed the title [colorManipulator] Support hsla in getLuminance [colorManipulator] Fix parsing of hsla colors in getLuminance Sep 22, 2022
@siriwatknp siriwatknp added bug 🐛 Something doesn't work package: system Specific to @mui/system labels Sep 23, 2022
siriwatknp
siriwatknp approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the contribution! looking forward to the next one.

@siriwatknp siriwatknp changed the title [colorManipulator] Fix parsing of hsla colors in getLuminance [system] Fix parsing of hsla colors in getLuminance Sep 26, 2022
@siriwatknp siriwatknp merged commit 6eff00f into mui:master Sep 26, 2022
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
@pete-murphy @alexfauquette
[system] Fix parsing of hsla colors in getLuminance (mui#34437)
81dc8f0
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@pete-murphy
[system] Fix parsing of hsla colors in getLuminance (mui#34437)
7643123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getLuminance doesn't work with hsla colors
3 participants
@pete-murphy @mui-bot @siriwatknp