[docs] Fix webpack file name to the standard: webpack.config.js
#34446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
docs
ZeeshanTamboli
changed the title
webpack.config.js
oliviertassinari
approved these changes
Sep 24, 2022
oliviertassinari
changed the title
webpack.config.jswebpack.config.js
|
@CodingItWrong It's a great first pull request on MUI 👌🏻. Thank you for working on it! |
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Styled Engine Guide, there is an example of configuring an alias in webpack. The file shown is labeled
webpack.alias.js; this PR updates it towebpack.config.js. Preview linkI think the intent here is just to indicate "put this in your webpack config," and
webpack.config.jsis the default webpack config file name. Additionally, the webpack docs for resolve.alias show the configuration inwebpack.config.js. Also, in trying out this config option I added it to mywebpack.config.jsand it succeeded.There are a few references around the web to
webpack.alias.js, but none in the webpack docs. I believe what happened here is that was the author was thinking about thealiasconfiguration, and accidentally put that into the file name.