[docs] Use mouse pointer on esc button in the search modal #34485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
Sep 26, 2022
packages/mui-codemod/src/v5.0.0/theme-spacing.test/large-actual.js
Outdated
Show resolved
Hide resolved
packages/mui-codemod/src/v5.0.0/theme-spacing.test/large-expected.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
reviewed
Sep 26, 2022
mnajdova
changed the title
oliviertassinari
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
The purist would say that only links should have a pointer cursor, but it's not the tradeoff that we decided to use. https://twitter.com/diegohaz/status/1555191381378928640
Eventually, I think that the search should be built with our own Omnibar component #32124
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34484