[IconButton] custom color causes type error #34521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hbjORbj
added
the
component: icon button
hbjORbj
changed the title
|
@siriwatknp would you mind reviewing it since you've been involved in the discussion in the issue? @kushagra010 From what I can see, the PR is lacking tests. |
michaldudak
requested review from
siriwatknp
and removed request for
mnajdova and
michaldudak
siriwatknp
reviewed
Nov 7, 2022
| ...(!ownerState.disableRipple && { | ||
| '&:hover': { | ||
| backgroundColor: theme.vars | ||
| ? `rgba(${theme.vars.palette[ownerState.color].mainChannel} / ${ | ||
| theme.vars.palette.action.hoverOpacity | ||
| })` | ||
| : alpha(theme.palette[ownerState.color].main, theme.palette.action.hoverOpacity), | ||
| : alpha( | ||
| theme.palette?.[ownerState.color]?.main ?? theme.palette.action.active, |
There was a problem hiding this comment.
Suggested change
| theme.palette?.[ownerState.color]?.main ?? theme.palette.action.active, | |
| theme.palette?.[ownerState.color]?.main ?? theme.palette.action.hover, |
…material-custom-color-causes-typeError-iconButton
2 tasks
siriwatknp
approved these changes
Nov 7, 2022
|
When will this get merged? |
It should be released next week, sorry for the delay. |
the-mgi
pushed a commit
to the-mgi/material-ui
that referenced
this pull request
Nov 17, 2022
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33054