Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Fix variantPlain classname missing in few components #34534

Merged
merged 1 commit into from Oct 3, 2022
Merged

[Joy] Fix variantPlain classname missing in few components #34534

merged 1 commit into from Oct 3, 2022

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Sep 30, 2022 •
edited

Problem:
-> For Alert, Badge and Chip components, variantPlain classname is missing.

@hbjORbj hbjORbj self-assigned this Sep 30, 2022
@mui-bot
Copy link

mui-bot commented Sep 30, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 7e81195

@hbjORbj hbjORbj added bug 🐛 Something doesn't work component: badge This is the name of the generic UI component, not the React module! component: chip This is the name of the generic UI component, not the React module! component: alert This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 30, 2022
siriwatknp
siriwatknp approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch!

@mnajdova mnajdova changed the title [Joy] variantPlain classname is missing [Joy] Fix variantPlain classname missing in few components Oct 3, 2022
@mnajdova mnajdova merged commit 73e5ade into mui:master Oct 3, 2022
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
@hbjORbj @alexfauquette
[Joy] Fix variantPlain classname missing in few components (mui#34534)
c7921bc
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@hbjORbj
[Joy] Fix variantPlain classname missing in few components (mui#34534)
8667526
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@hbjORbj
[Joy] Fix variantPlain classname missing in few components (mui#34534)
2a96c7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees

@hbjORbj hbjORbj

Labels
bug 🐛 Something doesn't work component: alert This is the name of the generic UI component, not the React module! component: badge This is the name of the generic UI component, not the React module! component: chip This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hbjORbj @mui-bot @siriwatknp @mnajdova