[docs] Fix SEO issues #34537
Merged
[docs] Fix SEO issues #34537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
fix-seo-issues-v8
branch
from
c64cd8b
to
518af4f
Compare
oliviertassinari
commented
Oct 1, 2022
| @@ -9,13 +9,11 @@ import BookmarkAdd from '@mui/icons-material/BookmarkAddOutlined'; | |||
|
|
|||
| export default function BasicCard() { | |||
| return ( | |||
| <Card variant="outlined" sx={{ minWidth: '320px' }}> | |||
| <Box sx={{ display: 'flex', flexDirection: 'column', gap: 0.5 }}> | |||
There was a problem hiding this comment.
Unecessary, removed
| <AspectRatio minHeight="120px" maxHeight="200px" sx={{ my: 2 }}> | ||
| <img | ||
| src="https://images.unsplash.com/photo-1527549993586-dff825b37782?crop=entropy&auto=format&fit=crop&w=3270" |
There was a problem hiding this comment.
| alt="" | ||
| /> | ||
| </AspectRatio> | ||
| <Box sx={{ display: 'flex' }}> | ||
| <div> | ||
| <Typography level="body3">Total price:</Typography> | ||
| <Typography fontSize="lg" fontWeight="lg"> | ||
| $2900 | ||
| $2,900 |
There was a problem hiding this comment.
en-US locale number format
| @@ -39,7 +39,7 @@ const vars = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| export default function GroupedAvatars() { | |||
| export default function CardVariables() { | |||
| @@ -137,7 +137,7 @@ | |||
| "stars": "GitHub stars", | |||
| "stickyFooterDescr": "Attach a footer to the bottom of the viewport when page content is short.", | |||
| "stickyFooterTitle": "Sticky footer", | |||
| "strapline": "MUI is a simple and customizable component library to build faster, beautiful, and more accessible React applications. Follow your own design system, or start with Material Design.", | |||
| "strapline": "MUI provides a simple, customizable, and accessible library of React components. Follow your own design system, or start with Material Design.", | |||
There was a problem hiding this comment.
This was too long & out of sync with the description on https://mui.com/index.html.
| @@ -11,7 +11,7 @@ import References, { CORE_CUSTOMERS } from 'docs/src/components/home/References' | |||
| import AppFooter from 'docs/src/layouts/AppFooter'; | |||
| import AppHeaderBanner from 'docs/src/components/banner/AppHeaderBanner'; | |||
|
|
|||
| export default function Home() { | |||
| export default function Core() { | |||
| @@ -31,7 +31,7 @@ export const getStaticProps = () => { | |||
| }; | |||
| }; | |||
|
|
|||
| const PostPreview = (props: BlogPost) => { | |||
| function PostPreview(props: BlogPost) { | |||
There was a problem hiding this comment.
Component convention.
| @@ -377,7 +377,7 @@ const appList = [ | |||
| title: 'HiFiveWork', | |||
| description: 'HiFiveWork, the cool tool for leave management', | |||
| image: 'hifivework.png', | |||
| link: 'https://www.hifivework.com/#/', | |||
| link: 'https://hifivework.com/', | |||
| alt="" | ||
| /> | ||
| </CardCover> | ||
| <CardContent sx={{ justifyContent: 'center', gap: 1 }}> |
There was a problem hiding this comment.
I could see no impacts from this CSS.
| alt="" | ||
| /> | ||
| </AspectRatio> | ||
| <Box> | ||
| <Box sx={{ ml: 0.5 }}> |
There was a problem hiding this comment.
This Box duplicates with the div and the gap prop.
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some of the issues in https://app.ahrefs.com/site-audit/3524616/32/issues.
Before: https://mui.com/joy-ui/react-card/
After: https://deploy-preview-34537--material-ui.netlify.app/joy-ui/react-card/
