Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid v2][system] handle direction object prop for responsive design #34574

Merged
merged 1 commit into from Oct 4, 2022
Merged

[Grid v2][system] handle direction object prop for responsive design #34574

merged 1 commit into from Oct 4, 2022

Conversation

vanyaxk
Copy link
Contributor

@vanyaxk vanyaxk commented Oct 2, 2022

resolves #34571

@mui-bot
Copy link

mui-bot commented Oct 2, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 49606e0

@siriwatknp siriwatknp added component: Grid The React component. PR: needs test The pull request can't be merged labels Oct 3, 2022
@siriwatknp
Copy link
Member

siriwatknp commented Oct 3, 2022 •
edited

@vanyaxk Thanks for the fix! Can you add a test to make sure that we don't make the same mistake in the future?

@siriwatknp siriwatknp added the package: system Specific to @mui/system label Oct 3, 2022
@siriwatknp siriwatknp changed the title fix(grid): handle direction object prop for responsive design [Grid v2][system] handle direction object prop for responsive design Oct 3, 2022
@vanyaxk vanyaxk force-pushed the fix/responsive-grid-class-bug branch from 3d14ff7 to a4bd0ea Compare October 3, 2022 15:58
@vanyaxk
Copy link
Contributor Author

vanyaxk commented Oct 3, 2022 •
edited

Added the test 🙂

@vanyaxk vanyaxk force-pushed the fix/responsive-grid-class-bug branch from a4bd0ea to 49606e0 Compare October 3, 2022 16:19
siriwatknp
siriwatknp approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

@siriwatknp siriwatknp merged commit e72393b into mui:master Oct 4, 2022
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
@vanyaxk @alexfauquette
[Grid v2][system] handle direction object prop for responsive design (m…
98eef81 
…ui#34574)
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@vanyaxk
[Grid v2][system] handle direction object prop for responsive design (m…
7b27798 
…ui#34574)
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@vanyaxk
[Grid v2][system] handle direction object prop for responsive design (m…
0195c25 
…ui#34574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: Grid The React component. package: system Specific to @mui/system PR: needs test The pull request can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Grid] Responsive direction prop breaks class slots
3 participants
@vanyaxk @mui-bot @siriwatknp