New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Fix unnecessary accessibility attribute in root element #34610
Merged
michaldudak
merged 1 commit into
mui:master
from
vanyaxk:fix/accessibility-issue-in-slider
Oct 5, 2022
Merged
[Slider] Fix unnecessary accessibility attribute in root element #34610
michaldudak
merged 1 commit into
mui:master
from
vanyaxk:fix/accessibility-issue-in-slider
Oct 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: slider
This is the name of the generic UI component, not the React module!
label
Oct 4, 2022
vanyaxk
force-pushed
the
fix/accessibility-issue-in-slider
branch
from
October 5, 2022 00:59
889feec
to
5ce1a9a
Compare
Thanks for your contribution! Could you please add a unit test that verifies the fixed behavior? |
michaldudak
changed the title
fix(slider): fix unnecessary accessibility attribute in root element
[Slider] Fix unnecessary accessibility attribute in root element
Oct 5, 2022
vanyaxk
force-pushed
the
fix/accessibility-issue-in-slider
branch
from
October 5, 2022 12:55
5ce1a9a
to
32c5b6f
Compare
Added the test, and edited the description, cheers 🙂 |
michaldudak
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accessibility
a11y
component: slider
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #34604 bug with a happy-path test