Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Taiwan description #34611

Merged
merged 1 commit into from Oct 5, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 4, 2022

Screenshot 2022-10-04 at 22 06 04

2005 version https://en.wikipedia.org/w/index.php?title=Taiwan&oldid=12192976, this comment looks legit to fix.

Screenshot 2022-10-04 at 22 06 21

cc @mj12albert is this OK?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 4, 2022
@mui-bot
Copy link

mui-bot commented Oct 4, 2022

No bundle size changes

Generated by 🚫 dangerJS against a694c36

@mj12albert
Copy link
Member

mj12albert commented Oct 5, 2022

@oliviertassinari While this is a huge (potential) political minefield of a topic, I think “Republic of China” per Wikipedia is objectively more accurate/correct.

Taiwan is not a province of China (like other provinces such as Fujian) on the bases (not exhaustive) that:

  • they issue their own passports that are accepted by other countries
  • they have their own currency that is internationally recognized
  • they have a system of government, legal system etc that is completely different from China & other provinces in mainland China

@oliviertassinari oliviertassinari merged commit ef9f93b into mui:master Oct 5, 2022
@oliviertassinari oliviertassinari deleted the taiwan branch October 5, 2022 14:35
@oliviertassinari
Copy link
Member Author

@mj12albert Thanks for the feedback :)

@yc-cui
Copy link

yc-cui commented Oct 5, 2022

Github is an open and inclusive site and we don't play politics. My suggestion would be to remove this section of the document or change this part of the document to something that is not controversial to reduce political controversy.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Oct 5, 2022

@cuiyc2000 I would agree with this, especially because we are aiming to grow the Chinese community but we need a country picker on the demo of the docs (a popular use case for the component). So I don't think that we can avoid this question 🙃

alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Oct 14, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants