[Joy] Add button loading functionality #34658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushagra010
requested review from
michaldudak,
mnajdova and
siriwatknp
as code owners
|
@mui/joy: parsed: +0.41% , gzip: +0.41% |
siriwatknp
added
component: button
siriwatknp
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
👍 Thanks for initiating the PR!
There are some changes that I decided to simplify
- I don't think the loading indicator slot is needed for positions
startandend. It is simpler to just render theCircularProgressas if it is a decorator. - Having only the
loadingIndicatorCenterslot because it must haveabsoluteposition to make it work. - Simplify CSS and reduce hard-coded values.
- Split demos into 2 parts, the
loadingand theloadingPosition.
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33999
Preview: https://deploy-preview-34658--material-ui.netlify.app/joy-ui/react-button/#loading