Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SwipeableDrawer] fixed typescript warning "prop open undefined" #34710

Merged
merged 15 commits into from Dec 12, 2022
Merged

[SwipeableDrawer] fixed typescript warning "prop open undefined" #34710

merged 15 commits into from Dec 12, 2022

Conversation

kraftware
Copy link
Contributor

@kraftware kraftware commented Oct 11, 2022 •
edited by michaldudak

Fixes #34709

@mui-bot
Copy link

mui-bot commented Oct 11, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-34710--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against f604d8d

@kraftware
Copy link
Contributor Author

fixing code is used in the same way in Drawer component already

@michaldudak michaldudak added package: material-ui Specific to @mui/material component: SwipeableDrawer The React component. labels Oct 12, 2022
michaldudak
michaldudak reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I left one comment. After you resolve it, please run yarn proptypes and yarn docs:api to generate the API docs and commit the changes.

packages/mui-material/src/SwipeableDrawer/SwipeableDrawer.d.ts Outdated Show resolved Hide resolved
kraftware and others added 3 commits December 7, 2022 17:24
@kraftware @michaldudak
Update packages/mui-material/src/SwipeableDrawer/SwipeableDrawer.d.ts
936f4f9 
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Signed-off-by: kraftware <kraft@artandbyte.de>
[SwipeableDrawer] adapted yarn docs:api
3e0f62e
Merge branch 'ts-warn-prop-open-undefined' of https://github.com/kraf…
b86bd8a 
…tware/material-ui into ts-warn-prop-open-undefined
@michaldudak
Copy link
Member

Could you please merge/rebase on the latest master? This should make visual regression tests happier.

@kraftware kraftware requested review from michaldudak and removed request for mnajdova December 8, 2022 12:53
michaldudak
michaldudak approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in order. Thanks for your work!

@michaldudak michaldudak merged commit 08bf5e6 into mui:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
component: SwipeableDrawer The React component. package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overriding SwipeableDrawer with shouldForwardProp leads to warning
3 participants
@kraftware @mui-bot @michaldudak