Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove date-io from the docs dependencies #34748

Merged
merged 4 commits into from Nov 1, 2022
Merged

[core] Remove date-io from the docs dependencies #34748

merged 4 commits into from Nov 1, 2022

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Oct 13, 2022 •
edited by oliviertassinari

Removed @date-io packages from docs dependencies as they are not used directly. It's @mui/x-date-pickers that depends and install them.

@michaldudak michaldudak added the website Pages that are not documentation-related, marketing-focused. label Oct 13, 2022
@michaldudak michaldudak mentioned this pull request Oct 13, 2022
Closed
1 task
@mui-bot
Copy link

mui-bot commented Oct 13, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-34748--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against d594fa0

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 24, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 26, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2022
siriwatknp
siriwatknp reviewed Nov 1, 2022
View reviewed changes
docs/package.json Outdated Show resolved Hide resolved
siriwatknp
siriwatknp reviewed Nov 1, 2022
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@siriwatknp
Apply suggestions from code review
d594fa0 
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@michaldudak michaldudak merged commit 3360a9c into mui:master Nov 1, 2022
@michaldudak michaldudak deleted the remove-dateio branch November 1, 2022 07:25
@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes and removed website Pages that are not documentation-related, marketing-focused. labels Nov 1, 2022
@oliviertassinari oliviertassinari changed the title [website] Remove date-io from the docs dependencies [core] Remove date-io from the docs dependencies Nov 1, 2022
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 1, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@michaldudak @siriwatknp
[website] Remove date-io from the docs dependencies (mui#34748)
1c8a5e8 
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@michaldudak @siriwatknp
[website] Remove date-io from the docs dependencies (mui#34748)
3164105 
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaldudak @mui-bot @siriwatknp @oliviertassinari