[test] Test all Base components with describeConformanceUnstyled #34825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
test
breaking change
component: modal
|
github-actions
bot
added
the
PR: out-of-date
michaldudak
force-pushed
the
describeConformanceUnstyled-in-base
branch
from
5a4e341
to
8564736
Compare
github-actions
bot
removed
the
PR: out-of-date
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
|
The project breaks on line 238 changes. If you pass a Root to ModalUnstyled, the function
|
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
|
@wallace-sf Could you please open a new issue and create a reproduction on codesandbox? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unstyled Modal and Popper weren't using all relevant
describeConformanceUnstyled's tests and TextareaAutosize was still using Material UI'sdescribeConformanceto test basic behavior. This PR fixes these issues.An issue with the Unstyled Modal was found along the way. It incorrectly prioritized
slots.rootovercomponent. Fixing this is a breaking change in Base, however, it should not affect most developers, as setting bothcomponentandslots.rootmakes no sense.This change doesn't affect the Material UI's Modal as it has its own logic for choosing between
slots.rootandcomponent.This PR also improves how
describeConformanceUnstyledworks with portaled components and improves error display in the ownerStatePropagation test.Breaking change
Prior to this change, if both
componentandslots.rootwere defined,slots.rootwould be used. After this PR,componentwill be chosen in this case.There are no use cases for having both
componentandslots.rootdefined at the same time. Remove one of them to reduce confusion.