[material-ui] Introduce the slots API #34873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
package: material-ui
michaldudak
requested review from
mnajdova,
siriwatknp and
hbjORbj
as code owners
@material-ui/core: parsed: +0.27% , gzip: +0.47% |
michaldudak
force-pushed
the
slots-in-material-ui
branch
from
601d64b
to
deef8d8
Compare
mnajdova
approved these changes
Nov 3, 2022
1 task
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #33416.
This PR introduces the
slotsandslotPropsprops in the components that havecomponentsandcomponentsProps, respectively. The new props work alongside the old ones. Where both old and new API is used, the new one takes precedence.This change is not supposed to break any existing codebases. It only adds new props without modifying the behavior of the old ones.
The PR also updates the conformance tests to make sure the new API works consistently across all components.