[docs] New API design rule disabled > disable #34972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
boolean-naming
branch
from
ad02435
to
1efd360
Compare
|
mnajdova
approved these changes
Nov 1, 2022
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
the-mgi
pushed a commit
to the-mgi/material-ui
that referenced
this pull request
Nov 17, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #34895. It's a quick iteration. From the outcome of the meeting, it seemed that the conclusion was: pick what's most consistent with the rest of the codebase. This definitely feels like what the rest of the codebase is doing.
Preview: https://deploy-preview-34972--material-ui.netlify.app/material-ui/guides/api/#prop-naming
Regarding #34895 (comment), I increasingly feel that A > B.