Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Add a missing key attribute in getInitColorScheme to fix key issue #34992

Merged
merged 1 commit into from Nov 3, 2022
Merged

[system] Add a missing key attribute in getInitColorScheme to fix key issue #34992

merged 1 commit into from Nov 3, 2022

Conversation

akshaya-venkatesh8
Copy link
Contributor

@akshaya-venkatesh8 akshaya-venkatesh8 commented Nov 3, 2022 •
edited

Fixes #34801

@mui-bot
Copy link

mui-bot commented Nov 3, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-34992--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against d005c81

@mnajdova mnajdova added bug 🐛 Something doesn't work package: system Specific to @mui/system labels Nov 3, 2022
mnajdova
mnajdova approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull request on MUI 👌 Thank you for working on it!

@mnajdova mnajdova merged commit 7a13baa into mui:master Nov 3, 2022
@mnajdova mnajdova changed the title Added a missing key attribute in getInitColorScheme to fix key issue [system] Add a missing key attribute in getInitColorScheme to fix key issue Nov 3, 2022
@akshaya-venkatesh8
Copy link
Contributor Author

Yay! Thank you so much! This is my first PR merge on MUI. Hope to contribute more!

daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@akshaya-venkatesh8
[system] Add a missing key attribute in getInitColorScheme to fix key…
3a5cd38 
… issue (mui#34992)
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@akshaya-venkatesh8
[system] Add a missing key attribute in getInitColorScheme to fix key…
2660061 
… issue (mui#34992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
3 participants
@akshaya-venkatesh8 @mui-bot @mnajdova