Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Export FormControl, LinearProgress and ListSubheader components from @mui/joy #35003

Merged
merged 2 commits into from Nov 14, 2022

Conversation

Studio384
Copy link
Contributor

@Studio384 Studio384 commented Nov 4, 2022

This pull request adds FormControl, LinearProgress and ListSubheader to the @mui/joy index so they can be exported from it.

- export FormControl from '@mui/joy/FormControl';
- export LinearProgress from '@mui/joy/LinearProgress';
- export ListSubheader from '@mui/joy/ListSubheader';
+ export { FormControl, LinearProgress, ListSubheader } from '@mui/joy';

It also moves some of the exports to be in alphabetical order like all others.

I couldn't find any discussion or reasoning on why these components weren't being exported from here, so my appologies if it has a reason.

@mui-bot
Copy link

mui-bot commented Nov 4, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35003--material-ui.netlify.app/

Details of bundle changes

@mui/joy: parsed: +2.47% , gzip: +1.69%

Generated by 🚫 dangerJS against d0db4af

@Studio384 Studio384 changed the title [FormControl] Export FormControl component from @mui/joy [Joy] Export FormControl, LinearProgress and ListSubheader components from @mui/joy Nov 4, 2022
@zannager zannager added the package: joy-ui Specific to @mui/joy label Nov 4, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

@michaldudak michaldudak merged commit 6582dd3 into mui:master Nov 14, 2022
the-mgi pushed a commit to the-mgi/material-ui that referenced this pull request Nov 17, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants