You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tried Windows on BrowserStack but they only stream with a 1 CSS pixel = 1 physical pixel (not 2) so it looked super blurry, I couldn't really judge. So I picked the font that Next.js uses that triggers on Windows, in lack of a better option, trusting they had designers testing this out. 👍 to check on Linux, iOS, Android what looks best.
@mnajdova Among the benchmark that I linked on this PR's description, is there one that feels better (easier to read) than the others on Windows? It doesn't look like a step forward on Windows IMHO.
Lucida Console is a font used in older (well, ancient ;)) versions of Windows. The one most widely used in code editors on Windows is Consolas (used by default by both VS Code and Visual Studio), followed by Cascadia Mono, more recently introduced by Microsoft.
Before:
After:
I personally like the "before" version more. Plus, it's a bit narrower, reducing the need to scroll horizontally.
bug 🐛Something doesn't workdocsImprovements or additions to the documentationregressionA bug, but worsescope: docs-infraSpecific to the docs-infra product
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oliviertassinari
added
bug 🐛
The regression was introduced in https://github.com/mui/material-ui/pull/34954/files#r1008895718. It wasn't such a good idea.
Instead, we can use https://reactjs.org/docs/higher-order-components.html, https://beta.nextjs.org/docs/optimizing/images, https://beta.reactjs.org/learn/state-as-a-snapshot, https://tailwindcss.com/docs/installation, VS Code font families as benchmarks for what might look best
Before: https://master--material-ui.netlify.app/material-ui/react-button/#basic-button
After: https://deploy-preview-35027--material-ui.netlify.app/material-ui/react-button/#basic-button