-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[core] Ignore unrelated folders from github actions #35028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this could cause a problem because CI / test-dev is a required check and, according to GitHub docs, when skipped, it'll stay in a Pending state forever (see the note under https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths). There is a workaround described in https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks |
Oh, nice. Forgot about the check. |
@michaldudak please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should do the trick. Let's test it in action.
🎉 It works! #35062 |
@siriwatknp There's a problem with running checks in PRs that change just the docs. See #35076 pull_request:
paths:
- 'docs/**'
- 'examples/**' won't trigger the "fake" action also for PRs that change both the docs and other code. We'll have two jobs with the same name running - I don't know if this can cause any problems. |
@siriwatknp what do you think about moving these tests to CircleCI? The value could be about having a single tool to run the CI. This means a single place to gather analytics about it, a single learning curve, or billing. For example, we could allocate larger machines. Regarding only running based on the file changed, we could copy material-ui/.circleci/config.yml Lines 167 to 168 in 9d94f27
|
Hey, I think that's another topic. My first intention is to skip the tests for non-related changes, not moving them to another provider. |
@siriwatknp My thought was that the day-to-day problem is that this CI task is the slowest. On CircleCI, we could give the environment that runs these scripts more CPUs, the task would no longer be the slowest one. Skipping unnecessary work sounds great too 👍 |
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths.
The
ci.yml
github action is all about packages check which is not related todocs
andexamples
folders. This PR will speed up the CI check.How to test?
I think we have to merge this one and open a fake PR that contains changes in docs/examples to test if the ignore works.