Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update DoiT International logo and links with new brand #35030

Merged
merged 2 commits into from Nov 8, 2022
Merged

[website] Update DoiT International logo and links with new brand #35030

merged 2 commits into from Nov 8, 2022

Conversation

ofir5300
Copy link
Contributor

@ofir5300 ofir5300 commented Nov 7, 2022

Hi, I am Ofir and I am a contributor from DoiT International side.
This PR solves 2 items:

  1. Due to DoiT domain update from doit-intl.com --> doit.com, all links in the repository was aligned
  2. DoiT rebrand - all logos replaced with new logo (see attached image from MUI website)

Screen Shot 2022-11-07 at 11 05 41

@zannager zannager added the website Pages that are not documentation-related, marketing-focused. label Nov 7, 2022
rel="noopener noreferrer sponsored"
target="_blank"
>
<img
height="26"
src="/static/sponsors/doit.svg"
alt="doit-intl"
src={`/static/sponsors/doit-${theme.palette.mode}.svg`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be the other way around? It currently shows the doit-light logo (with white letters) on a white background (see https://deploy-preview-35030--material-ui.netlify.app/material-ui/getting-started/overview/)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, thanks for the spot.
Fixed.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.
Let me just figure out why the CI fails - there seems to be an authentication problem.

@michaldudak michaldudak merged commit 43408b1 into mui:master Nov 8, 2022
@ofir5300
Copy link
Contributor Author

ofir5300 commented Nov 17, 2022

Hey @michaldudak
I see that in some of the areas in mui both our logo and link seems broken. example here
Can you assist?
Or direct me to where in the code it relies?
Screenshot 2022-11-17 at 11 54 32

Edit: I see you already have an open pr for that. I wonder if I should do anything from our side? @michaldudak @m4theushw

the-mgi pushed a commit to the-mgi/material-ui that referenced this pull request Nov 17, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants