Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Link respective repositories in product pages #35046

Merged
merged 2 commits into from Nov 12, 2022

Conversation

sidtohan
Copy link
Contributor

@sidtohan sidtohan commented Nov 8, 2022

  • Modified AppHeader.tsx to detect the current product and link the github icon to the appropriate repository.

Fixes #34336

A continuation of #34889

modified AppHeader.tsx to detect the current product and link the github icon to the appropriate repository
@mui-bot
Copy link

mui-bot commented Nov 8, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35046--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against c35b6c0

@zannager zannager added the website Pages that are not documentation-related, marketing-focused. label Nov 8, 2022
@sidtohan
Copy link
Contributor Author

sidtohan commented Nov 9, 2022

@oliviertassinari can you have a look at this? I have removed concatenation as you suggested.

@oliviertassinari oliviertassinari changed the title [website] Product pages now link to their respective repository [website] Link respective repositories in product pages Nov 9, 2022
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Nov 9, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 9, 2022

@sidtohan Thanks, I have pushed a few changes with the goal to simplify the implementation. It seems that we can give control to the page that renders these components. I think it's simpler (e.g. won't break when the URL changes) but it's not for me to carry forward so I'm leaving the PR. I'm adding as reviewers the two people that were involved in the GitHub issue.

If we move forward with this approach, this will need to be updated: https://github.com/mui/mui-toolpad/blob/213103a8b1dd1a877939b083fb833aeef35e2ec1/docs/pages/toolpad/index.js#L41. @bharatkashyap Could you take care of it? Thanks cc @Janpot who raised the confusion during a Toolpad's meeting.

@oliviertassinari oliviertassinari merged commit cb278c4 into mui:master Nov 12, 2022
the-mgi pushed a commit to the-mgi/material-ui that referenced this pull request Nov 17, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to repository from landing pages instead of organisation
5 participants