[docs] Improve code font family v2 #35053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oliviertassinari
force-pushed
the
font-code
branch
from
9ae15aa
to
cdf6187
Compare
oliviertassinari
requested review from
siriwatknp,
flaviendelangle and
michaldudak
|
The screenshot are in the order of the links above |
michaldudak
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Much better, thanks!
Off-topic, I saw a few interesting custom fonts used during my benchmark
I use JetBrains Mono in my editors and I'm very satisfied with it.
flaviendelangle
approved these changes
Nov 10, 2022
the-mgi
pushed a commit
to the-mgi/material-ui
that referenced
this pull request
Nov 17, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Act on #35027 (comment). I think that we have it right this time on macOS and Windows. We match the default font on VS Code.
Regarding Linux, I'm not sure. @flaviendelangle As you are on Linux, do you see changes between
Before: https://631f4503cb19a90009794dfc--material-ui-docs.netlify.app/material-ui/react-alert/#basic-alerts
After: https://deploy-preview-35053--material-ui.netlify.app/material-ui/react-alert/#basic-alerts?
I'm adding 3 reviewers, each on a different platform.
Off-topic, I saw a few interesting custom fonts used during my benchmark:
ReplitHack