Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Fix TypeScript type for custom variants in responsive font sizes #35057

Merged
merged 10 commits into from Nov 25, 2022
Merged

[theme] Fix TypeScript type for custom variants in responsive font sizes #35057

merged 10 commits into from Nov 25, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Nov 9, 2022 •
edited

@ZeeshanTamboli ZeeshanTamboli changed the title Issue/34503 responsive font sizes custom variants [theme] Fix responsive font sizes custom variants typescript type Nov 9, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [theme] Fix responsive font sizes custom variants typescript type [theme] Fix responsive font sizes custom variants TypeScript type Nov 9, 2022
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript customization: theme Centered around the theming features labels Nov 9, 2022
@mui-bot
Copy link

mui-bot commented Nov 9, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35057--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 778bd61

@ZeeshanTamboli ZeeshanTamboli changed the title [theme] Fix responsive font sizes custom variants TypeScript type [theme] Fix TypeScript type for custom variants in responsive font sizes Nov 9, 2022
@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review November 9, 2022 06:55
siriwatknp
siriwatknp approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great!

@ZeeshanTamboli ZeeshanTamboli merged commit 114977a into mui:master Nov 25, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/34503-responsiveFontSizes-custom-variants branch November 25, 2022 07:03
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@ZeeshanTamboli
[theme] Fix TypeScript type for custom variants in responsive font si…
d9810f7 
…zes (mui#35057)
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@ZeeshanTamboli
[theme] Fix TypeScript type for custom variants in responsive font si…
a3e6903 
…zes (mui#35057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work customization: theme Centered around the theming features typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

responsiveFontSizes does not respect use of custom variants
3 participants
@ZeeshanTamboli @mui-bot @siriwatknp