Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix markActive theme class not getting applied #35067

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Nov 9, 2022

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! labels Nov 9, 2022
@mui-bot
Copy link

mui-bot commented Nov 9, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35067--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against e1e8694

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review November 9, 2022 13:23
@ZeeshanTamboli ZeeshanTamboli changed the title [Slider] Fix markActive theme class not applied [Slider] Fix markActive theme class not getting applied Nov 9, 2022
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for your work, Zeeshan!

@ZeeshanTamboli ZeeshanTamboli merged commit 2eb98c5 into mui:master Dec 6, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/35063-markActive-theme-class branch December 6, 2022 09:52
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Dec 6, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] markActive theme class not applied
3 participants