[Divider] Fix styles on dividers with text #35072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Destors <max.destors@leptech.net>
Netlify deploy previewhttps://deploy-preview-35072--material-ui.netlify.app/ Bundle size report |
zannager
added
the
component: divider
|
I have the same problem. I hope it will be merged soon. @siriwatknp |
siriwatknp
reviewed
Jan 3, 2023
|
@siriwatknp Thanks for the review ! I also fixed the vertical orientation. |
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
@maxdestors It looks good. The style fixes are a good improvement. I also removed the now unnecessary position: relative in 2bebb95. Thanks for the first pull request!
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Signed-off-by: Max Destors <max.destors@leptech.net> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior :
Correction :
Here is a sandBox to reproduce : https://codesandbox.io/s/divider-before-after-height-bug-071123?file=/src/App.tsx