Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Correct the keepMounted section on the Drawer page #35076

Merged
merged 5 commits into from Nov 14, 2022

Conversation

michaldudak
Copy link
Member

A follow-up to #34505 in response to the comment: #34505 (comment).

This PR changes the keepMounted prop description to underline it's set to true by default.

@michaldudak michaldudak added docs Improvements or additions to the documentation component: SwipeableDrawer The React component. labels Nov 9, 2022
@mui-bot
Copy link

mui-bot commented Nov 9, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35076--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against c65cc6e

@mnajdova
Copy link
Member

Thanks for taking care of this.

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple tiny things!

docs/data/material/components/drawers/drawers.md Outdated Show resolved Hide resolved
docs/data/material/components/drawers/drawers.md Outdated Show resolved Hide resolved
michaldudak and others added 2 commits November 11, 2022 09:21
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
@michaldudak michaldudak merged commit b7e2366 into mui:master Nov 14, 2022
@michaldudak michaldudak deleted the drawer-keepMounted-docs branch November 14, 2022 11:54
the-mgi pushed a commit to the-mgi/material-ui that referenced this pull request Nov 17, 2022
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: SwipeableDrawer The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants