Convert icons scripts to ESM #35101
Merged
Convert icons scripts to ESM #35101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
We run it roughly every 3 months (manually). It could be automated for sure, but the effort to do it is likely several times larger than running two scripts by hand :) Actually, let me update the icons now, so it's easier to verify if the changes you made to the scripts don't change the output (#35194). |
|
I've updated the icon set. Could you please merge in the latest master? |
michaldudak
approved these changes
Nov 21, 2022
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Nov 22, 2022
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the scripts in
@mui/icons-materialto ESM, and removebabel-nodeAdding
.sort()togenerateIndexto guarantee cross platform order of exports.Nota bene: running
yarn src:downloadproduces several updated svgs. What's the policy around syncing icons? Is it being run periodically? Is it/can it be automated?