Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix bugs with live edit demos #35106

Merged
merged 1 commit into from Nov 14, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 12, 2022

Fix issue 2 reported in #34870 (comment). To reproduce:

  1. Open https://mui.com/material-ui/react-switch/#basic-switches
  2. Enjoy, the switch shouldn't change its state

bad

This is particularly a bad UX on the data grid demos, where you most often need to open the demos, and where you lose the state of what you were looking at on the grid.

https://deploy-preview-35106--material-ui.netlify.app/material-ui/react-switch/#basic-switches

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Nov 12, 2022
@mui-bot
Copy link

mui-bot commented Nov 12, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35106--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against cf213c5

@oliviertassinari oliviertassinari merged commit 5292e98 into mui:master Nov 14, 2022
@oliviertassinari oliviertassinari deleted the live-edit-v3 branch November 14, 2022 10:34
the-mgi pushed a commit to the-mgi/material-ui that referenced this pull request Nov 17, 2022
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Nov 21, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants