[docs] Fix code editor styles mismatches #35108
Merged
+18
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
fix-display-regression
branch
from
3459b10 to
783d21b
Compare
|
oliviertassinari
force-pushed
the
fix-display-regression
branch
from
783d21b to
e23fa1f
Compare
| @@ -123,7 +123,7 @@ export function AdCarbonInline(props) { | |||
| /> | |||
| </React.Fragment> | |||
| ) : ( | |||
| <div {...props} style={{ minHeight: 45 }} /> | |||
| <div {...props} style={{ minHeight: 52 }} /> | |||
| @@ -14,8 +15,7 @@ const StyledMarkdownElement = styled(MarkdownElement)(({ theme }) => ({ | |||
| '& .scrollContainer': { | |||
| maxHeight: 'min(68vh, 1000px)', | |||
| overflow: 'auto', | |||
| backgroundColor: `${blueDark[800]} !important`, | |||
| borderRadius: theme.shape.borderRadius, | |||
| backgroundColor: blueDark[800], | |||
There was a problem hiding this comment.
No need for !important.
Comment on lines
+30
to
+31
| [theme.breakpoints.up('sm')]: { | ||
| borderRadius: theme.shape.borderRadius, | ||
| }, |
There was a problem hiding this comment.
Fix code preview that look strange on mobile
Before:
https://mui.com/material-ui/react-skeleton/#animations
After:
https://deploy-preview-35108--material-ui.netlify.app/material-ui/react-skeleton/#animations
| @@ -46,6 +46,7 @@ const adBodyInlineStyles = (theme) => { | |||
| ...baseline, | |||
| root: { | |||
| display: 'block', | |||
| paddingTop: 8, | |||
There was a problem hiding this comment.
| @@ -100,7 +104,7 @@ export default function DemoEditor(props: DemoEditorProps) { | |||
| <div className="MuiCode-root" {...handlers}> | |||
| <div className="scrollContainer"> | |||
| <StyledSimpleCodeEditor | |||
| padding={20} | |||
| padding={contextTheme.spacing(2)} | |||
There was a problem hiding this comment.
To equal
oliviertassinari
force-pushed
the
fix-display-regression
branch
from
e23fa1f to
5a3f18b
Compare
Comment on lines
+274
to
+284
| const DemoCodeViewer = styled(HighlightedCode)(({ theme }) => ({ | ||
| '& pre': { | ||
| margin: '0 auto', | ||
| margin: 0, | ||
| maxHeight: 'min(68vh, 1000px)', | ||
| maxWidth: 'initial', | ||
| borderRadius: 0, | ||
| [theme.breakpoints.up('sm')]: { | ||
| borderRadius: theme.shape.borderRadius, | ||
| }, | ||
| }, | ||
| }); | ||
| })); |
There was a problem hiding this comment.
Fix demos that have , "disableLiveEdit":true}} on mobile, Before:
After:
Merged
bharatkashyap
approved these changes
Nov 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix point 3 and 4 in #34870 (comment).