Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Host CodeSandbox on MUI org #35110

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 12, 2022

I have opened this to illustrate the value of creating the codesandbox under the MUI org, this way, anyone can come in make fixes without updating the markdown. I didn't try to solve all the instances of the problem, as my main goal is to raise this opportunity.

Before

Screenshot 2022-11-12 at 18 30 48

After

Screenshot 2022-11-12 at 18 33 21

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material package: joy-ui Specific to @mui/joy labels Nov 12, 2022
Comment on lines 121 to +123
const muiTheme = extendMuiTheme({
// This is required to point to `var(--joy-*)` because we are using `CssVarsProvider` from Joy UI.
// This is required to point to `var(--joy-*)` because we are using
// `CssVarsProvider` from Joy UI.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comment changes are to remove the horizontal scrollbar.

@mui-bot
Copy link

mui-bot commented Nov 12, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35110--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against da50d18

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sounds good to me.

@oliviertassinari oliviertassinari merged commit 6571d36 into mui:master Nov 15, 2022
@oliviertassinari oliviertassinari deleted the move-codesandbox-to-org branch November 15, 2022 12:39
the-mgi pushed a commit to the-mgi/material-ui that referenced this pull request Nov 17, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants