New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Host CodeSandbox on MUI org #35110
Merged
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:move-codesandbox-to-org
Nov 15, 2022
Merged
[docs] Host CodeSandbox on MUI org #35110
oliviertassinari
merged 1 commit into
mui:master
from
oliviertassinari:move-codesandbox-to-org
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
package: joy-ui
Specific to @mui/joy
labels
Nov 12, 2022
oliviertassinari
force-pushed
the
move-codesandbox-to-org
branch
from
November 12, 2022 17:33
b8a516e
to
da50d18
Compare
Comment on lines
121
to
+123
const muiTheme = extendMuiTheme({ | ||
// This is required to point to `var(--joy-*)` because we are using `CssVarsProvider` from Joy UI. | ||
// This is required to point to `var(--joy-*)` because we are using | ||
// `CssVarsProvider` from Joy UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comment changes are to remove the horizontal scrollbar.
|
siriwatknp
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Sounds good to me.
the-mgi
pushed a commit
to the-mgi/material-ui
that referenced
this pull request
Nov 17, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Improvements or additions to the documentation
package: joy-ui
Specific to @mui/joy
package: material-ui
Specific to @mui/material
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have opened this to illustrate the value of creating the codesandbox under the MUI org, this way, anyone can come in make fixes without updating the markdown. I didn't try to solve all the instances of the problem, as my main goal is to raise this opportunity.
Before
After