[website] Improve visual design app bar #35111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
design
|
danilo-leal
reviewed
Nov 15, 2022
Signed-off-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
danilo-leal
approved these changes
Nov 15, 2022
|
It looks good 👍, my main concern was the broken contrast ratio when the appbar hovers a dark area in light mode. |
|
@danilo-leal Regarding Did you expect to update the docs as well? e.g. https://deploy-preview-35111--material-ui.netlify.app/material-ui/getting-started/overview/ is still using 20px |
1 task
|
I did, yeah! There you go a PR making it consistent ☝️ |
the-mgi
pushed a commit
to the-mgi/material-ui
that referenced
this pull request
Nov 17, 2022
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A visual bug that I saw on https://mui.com/blog/date-pickers-stable-v5/
Before
After
The dark background color leaks too much into the app bar, reducing the opacity helps, I'm not sure that I went far enough, but at least, this feels already a step forward.