[Autocomplete][Joy] Fix types #35153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: autocomplete
|
siriwatknp
commented
Nov 15, 2022
Comment on lines
85
to
86
| Omit<AutocompleteOwnerState<any, any, any, any>, 'color' | 'variant' | 'size'> & | ||
| Pick<IconButtonOwnerState, 'color' | 'variant' | 'size'> |
There was a problem hiding this comment.
Pick only the styling props from the IconButton to remove the above typecasting.
There was a problem hiding this comment.
Why is IconButtonOwnerState needed here? ownerState is supposed to be the state of the owner - that is Autocomplete in this case.
There was a problem hiding this comment.
Right, move them to props.
michaldudak
approved these changes
Nov 15, 2022
the-mgi
pushed a commit
to the-mgi/material-ui
that referenced
this pull request
Nov 17, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove outdated
AutocompleteRenderInputParamsand get rid of typecasting.