Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve the autogenerated "Unstyled" and "API" text #35185

Merged
merged 3 commits into from Nov 29, 2022

Conversation

samuelsycamore
Copy link
Member

@samuelsycamore samuelsycamore commented Nov 18, 2022

This PR updates the copy for the "Unstyled" and "API" sections of the docs pages. I always felt that the earlier version of the "Unstyled" text lacked clarity and context, and that the "API" section could use a description to explain what's on the other side of the links.

Before:

Screen Shot 2022-11-17 at 6 00 44 PM

After:

Screen Shot 2022-11-17 at 6 10 59 PM

https://deploy-preview-35185--material-ui.netlify.app/material-ui/react-select/#unstyled

@samuelsycamore samuelsycamore added the docs Improvements or additions to the documentation label Nov 18, 2022
@mui-bot
Copy link

mui-bot commented Nov 18, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35185--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 8bca7df

@@ -414,14 +414,18 @@ function prepareMarkdown(config) {
contents.push(`
## Unstyled

The component also comes with an [unstyled version](${headers.unstyled}). It's ideal for doing heavy customizations and minimizing bundle size.
:::success
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unclear to me that it should be an alert. I think that the least often we use callouts, the more they mean something. But why not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong feeling about it either way. The reasoning was that we've started to use the :::success callout as a way to alert the reader about helpful hints or useful patterns/practices, and I felt that the info here fits that description. I also like that it draws more attention to the existence of Base (for educational/awareness purposes). But I think it would be fine without the callout, too.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I don't have strong opinions about the callout.

@samuelsycamore
Copy link
Member Author

Let's keep the callout for now. If we decide it's too annoying or distracting we can always remove it later.

@samuelsycamore samuelsycamore merged commit 9949df0 into mui:master Nov 29, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 30, 2022

Regarding the callout type. Why use a success type? Should it be more of an info callout? https://master--material-ui.netlify.app/experiments/docs/callouts/

feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@samuelsycamore samuelsycamore deleted the unstyled-section branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants