Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Migrate describeConformance to TypeScript #35193

Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 18, 2022

Not much to say here, I just migrated this file to TypeScript, right now using JS utils on the X repo is painful.
There should be no behavior change

@flaviendelangle flaviendelangle added test core Infrastructure work going on behind the scenes labels Nov 18, 2022
@flaviendelangle flaviendelangle self-assigned this Nov 18, 2022
@flaviendelangle flaviendelangle changed the title [core] Migrate describeConformance to TypeScript [core] Migrate describeConformance to TypeScript Nov 18, 2022
@mui-bot
Copy link

mui-bot commented Nov 18, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35193--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 1eb6e22

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we convert at least one test file that uses both test suites to ensure the types are correct?

@flaviendelangle
Copy link
Member Author

@mnajdova how do you mean by "both test suites" ?

We have several test files using describeConformance
Do you want one using both describeConformanceUnstyled and describeConformance ?

@mnajdova
Copy link
Member

We have several test files using describeConformance

I meant to convert one of these test files to be TypeScript file instead of JavaScript (maybe Button.test.js -> Button.test.tsx). For the unstyled components we should be covered, as the tests are already written in TypeScript.

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Nov 22, 2022

@mnajdova but we already have some of them in TS (23 in fact)
For instance Autocomplete, Stepper or Divider calls to describeConformance are done in TS files

I can migrate other to TS of course but I don't think it will catch anything new.

@mnajdova
Copy link
Member

Ah, I have missed these, alright, thansk for pointing out.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flaviendelangle flaviendelangle merged commit bf8b632 into mui:master Nov 22, 2022
@flaviendelangle flaviendelangle deleted the type-describeConformance branch November 22, 2022 14:07
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants