-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Migrate describeConformance
to TypeScript
#35193
[core] Migrate describeConformance
to TypeScript
#35193
Conversation
31943ec
to
18a75e2
Compare
describeConformance
to TypeScript
|
18a75e2
to
1eb6e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we convert at least one test file that uses both test suites to ensure the types are correct?
@mnajdova how do you mean by "both test suites" ? We have several test files using |
I meant to convert one of these test files to be TypeScript file instead of JavaScript (maybe Button.test.js -> Button.test.tsx). For the unstyled components we should be covered, as the tests are already written in TypeScript. |
@mnajdova but we already have some of them in TS (23 in fact) I can migrate other to TS of course but I don't think it will catch anything new. |
Ah, I have missed these, alright, thansk for pointing out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not much to say here, I just migrated this file to TypeScript, right now using JS utils on the X repo is painful.
There should be no behavior change