Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix a couple documentation errors #35217

Merged
merged 2 commits into from Nov 22, 2022

Conversation

danilo-leal
Copy link
Contributor

Mostly a follow-up to a recently merged PR (#34316) in which I just realized a couple of things were still broken. @siriwatknp let me know about a better way to do the Autocomplete's playground demo work on dark & light mode, as it's using ternary and hard-coded RGBa values (as they're from the branding theme).

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Nov 21, 2022
@mui-bot
Copy link

mui-bot commented Nov 21, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35217--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 2d4c8d4

@siriwatknp
Copy link
Member

let me know about a better way to do the Autocomplete's playground demo work on dark & light mode, as it's using ternary and hard-coded RGBa values (as they're from the branding theme).

👍 This is fine.

@siriwatknp siriwatknp merged commit b8b1e0d into mui:master Nov 22, 2022
@siriwatknp siriwatknp changed the title [Joy] Fix a couple documentation errors [docs] Fix a couple documentation errors Nov 22, 2022
alexfauquette pushed a commit to alexfauquette/material-ui that referenced this pull request Nov 22, 2022
@danilo-leal danilo-leal deleted the fix-joy-demos branch November 22, 2022 15:25
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants