Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Remove unnecessary handleKeyDown event handler #35231

Merged
merged 2 commits into from Nov 23, 2022
Merged

[Chip] Remove unnecessary handleKeyDown event handler #35231

merged 2 commits into from Nov 23, 2022

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli added test component: chip This is the name of the generic UI component, not the React module! labels Nov 22, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [Chip] Remove unnecessary handleKeyDown event handler from test [Chip] Remove unnecessary handleKeyDown event handler Nov 22, 2022
@mui-bot
Copy link

mui-bot commented Nov 22, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35231--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 701d091

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review November 22, 2022 14:34
siriwatknp
siriwatknp approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ZeeshanTamboli ZeeshanTamboli merged commit 798b83d into mui:master Nov 23, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the remove-handlekeydown-from-chip-test branch November 23, 2022 13:59
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@ZeeshanTamboli
[Chip] Remove unnecessary handleKeyDown event handler (mui#35231)
1a8f708
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@ZeeshanTamboli
[Chip] Remove unnecessary handleKeyDown event handler (mui#35231)
199419a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: chip This is the name of the generic UI component, not the React module! test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZeeshanTamboli @mui-bot @mnajdova @siriwatknp