Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Fix Next.js errors #35246

Merged
merged 2 commits into from Nov 24, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 23, 2022

  1. examples/nextjs-with-typescript-v4-migration is meant to show how to use @mui/styles, so React 17 only, which doesn't work with Next 13 (React 18). It currently crashes when you follow https://github.com/mui/material-ui/tree/master/examples/nextjs-with-typescript-v4-migration.
  2. I forgot to remove passHref in [docs] Push the fixes on Next.js's Link to the examples #28178
  3. We did a fix in [examples] Fix NextLinkComposedProps type error #33842 but forgot about the other examples

@oliviertassinari oliviertassinari added examples Relating to /examples bug 🐛 Something doesn't work regression A bug, but worse labels Nov 23, 2022
@mui-bot
Copy link

mui-bot commented Nov 23, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35246--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 6eec567

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari merged commit 7fa0a8b into mui:master Nov 24, 2022
@oliviertassinari oliviertassinari deleted the leftover branch November 24, 2022 14:43
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work examples Relating to /examples nextjs regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants